Skip to content

Refactor service registry to avoid use of getattr #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Sep 23, 2021
Merged

Refactor service registry to avoid use of getattr #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions zeroconf/_services/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@ def async_get_types(self) -> List[str]:

def async_get_infos_type(self, type_: str) -> List[ServiceInfo]:
"""Return all ServiceInfo matching type."""
return self._async_get_by_index("types", type_)
return self._async_get_by_index(self.types, type_)

def async_get_infos_server(self, server: str) -> List[ServiceInfo]:
"""Return all ServiceInfo matching server."""
return self._async_get_by_index("servers", server)
return self._async_get_by_index(self.servers, server)

def _async_get_by_index(self, attr: str, key: str) -> List[ServiceInfo]:
def _async_get_by_index(self, records: Dict[str, List], key: str) -> List[ServiceInfo]:
"""Return all ServiceInfo matching the index."""
return [self._services[name] for name in getattr(self, attr).get(key.lower(), [])]
return [self._services[name] for name in records.get(key.lower(), [])]

def _add(self, info: ServiceInfo) -> None:
"""Add a new service under the lock."""
Expand Down