Skip to content

Seperate zeroconf._protocol into an incoming and outgoing modules#988

Merged
bdraco merged 5 commits into
python-zeroconf:masterfrom
bdraco:split_protocol
Sep 19, 2021
Merged

Seperate zeroconf._protocol into an incoming and outgoing modules#988
bdraco merged 5 commits into
python-zeroconf:masterfrom
bdraco:split_protocol

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 19, 2021

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2021

Codecov Report

Merging #988 (8363e4a) into master (f4665fc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #988   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        23    +2     
  Lines         2488      2502   +14     
  Branches       408       408           
=========================================
+ Hits          2488      2502   +14     
Impacted Files Coverage Δ
zeroconf/_dns.py 100.00% <ø> (ø)
zeroconf/__init__.py 100.00% <100.00%> (ø)
zeroconf/_core.py 100.00% <100.00%> (ø)
zeroconf/_handlers.py 100.00% <100.00%> (ø)
zeroconf/_protocol/__init__.py 100.00% <100.00%> (ø)
zeroconf/_protocol/incoming.py 100.00% <100.00%> (ø)
zeroconf/_protocol/outgoing.py 100.00% <100.00%> (ø)
zeroconf/_services/browser.py 100.00% <100.00%> (ø)
zeroconf/_services/info.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4665fc...8363e4a. Read the comment docs.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Sep 19, 2021

Screen Shot 2021-09-18 at 4 29 05 PM

incoming.py is still the most expensive file in every profile for Home Assistant.

At least its a lot better than it was last month.

@bdraco bdraco changed the title Seperate zeroconf._protocol into an incoming and outgoing module Seperate zeroconf._protocol into an incoming and outgoing modules Sep 19, 2021
@bdraco bdraco merged commit 87b6a32 into python-zeroconf:master Sep 19, 2021
@bdraco bdraco deleted the split_protocol branch September 19, 2021 02:39
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Sep 19, 2021

Should have been Separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants