Collapse _GLOBAL_DONE into done#984
Merged
Merged
Conversation
- Since there the other attributes are not protected, it was inconsistent to protect this one.
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2481 2478 -3
Branches 406 406
=========================================
- Hits 2481 2478 -3
Continue to review full report at Codecov.
|
bdraco
commented
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hook was primarily used for threads that no longer exist.
Since there the other attributes are not protected, it was inconsistent to
protect this one.