Defer decoding known answers until needed#983
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2481 2493 +12
Branches 406 408 +2
=========================================
+ Hits 2481 2493 +12
Continue to review full report at Codecov.
|
Member
Author
|
I wasn't expecting this much performance improvement, but event the 60s callgrind snapshot files are noticeably smaller.
|
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we decode all known the answers in the packet even if we never need to look at them because we can't answer any of the questions in the packet
Decoding packets is the most expensive operation zeroconf performs on active networks. In fact it's the most expensive operation on a mostly idle home assistant instance.
Defer decoding to only when we need to check for suppression to save cpu time.
Closes Lazy decode known answers #980