Skip to content

Reduce duplicate code to write records#979

Merged
bdraco merged 3 commits into
python-zeroconf:masterfrom
bdraco:reduce_records_writes
Sep 16, 2021
Merged

Reduce duplicate code to write records#979
bdraco merged 3 commits into
python-zeroconf:masterfrom
bdraco:reduce_records_writes

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 16, 2021

No description provided.

@bdraco bdraco marked this pull request as ready for review September 16, 2021 20:26
@bdraco bdraco force-pushed the reduce_records_writes branch from 5986300 to e68d873 Compare September 16, 2021 20:26
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #979 (e68d873) into master (769b397) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #979      +/-   ##
===========================================
- Coverage   100.00%   99.55%   -0.45%     
===========================================
  Files           21       21              
  Lines         2489     2481       -8     
  Branches       411      406       -5     
===========================================
- Hits          2489     2470      -19     
- Misses           0        6       +6     
- Partials         0        5       +5     
Impacted Files Coverage Δ
zeroconf/_protocol.py 100.00% <100.00%> (ø)
zeroconf/_utils/net.py 95.47% <0.00%> (-4.53%) ⬇️
zeroconf/const.py 97.33% <0.00%> (-2.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d6fc3...e68d873. Read the comment docs.

@bdraco bdraco force-pushed the reduce_records_writes branch from e68d873 to e289d9f Compare September 16, 2021 20:46
@bdraco bdraco merged commit acf6457 into python-zeroconf:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants