Skip to content

Sort responses to increase chance of name compression#954

Merged
bdraco merged 2 commits into
python-zeroconf:masterfrom
bdraco:group_names_answers
Aug 13, 2021
Merged

Sort responses to increase chance of name compression#954
bdraco merged 2 commits into
python-zeroconf:masterfrom
bdraco:group_names_answers

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Aug 13, 2021

  • When building an outgoing response, sort the names together
    to increase the likelyhood of name compression. In testing
    this reduced the number of packets for large responses
    (from 7 packets to 6)

closes #953

bdraco added 2 commits August 12, 2021 21:33
- When building an outgoing response, sort the names together
  to increase the likelyhood of name compression. In testing
  this reduced the number of packets for large responses
  (from 7 packets to 6)
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #954 (42171fb) into master (9d69d18) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #954   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2427      2428    +1     
  Branches       400       401    +1     
=========================================
+ Hits          2427      2428    +1     
Impacted Files Coverage Δ
zeroconf/_handlers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d69d18...42171fb. Read the comment docs.

@bdraco bdraco merged commit ebc23ee into python-zeroconf:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximize name compression opportunity in aggregated responses

2 participants