Add support for forward dns compression pointers#934
Conversation
7af6517 to
fcdcac4
Compare
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2315 2342 +27
Branches 383 387 +4
=========================================
+ Hits 2315 2342 +27
Continue to review full report at Codecov.
|
- nslookup supports these and some implementations (likely avahi) will generate them - Careful attention was given to make sure we detect loops and do not create anti-patterns described in https://github.com/Forescout/namewreck/blob/main/rfc/draft-dashevskyi-dnsrr-antipatterns-00.txt
fcdcac4 to
0a36cc6
Compare
|
The most common case we see in the wild is a NSEC record with invalid compression in the next name. Since mDNS currently doesn't care what that value is, I'm guessing nobody ever checked that it works. |
|
Works like a charm at my system. No more errors, everything seems to function well. |
|
I'm doing some more testing with this, and it all looks good. Github is broken right now https://www.githubstatus.com/incidents/7p1nnvkgh96y so I'll have to wait until later today or tomorrow to finish up #935 as I'd like to improve the error logging before releasing a new version so we can track down the root cause of home-assistant/core#54033 |
nslookup supports these and some implementations (likely avahi)
will generate them
Careful attention was given to make sure we detect loops
and do not create anti-patterns described in
https://github.com/Forescout/namewreck/blob/main/rfc/draft-dashevskyi-dnsrr-antipatterns-00.txt
Fixes home-assistant/core#53937
Fixes home-assistant/core#46985
Fixes home-assistant/core#53668
Fixes #308