Skip to content

Run question answer callbacks from add_listener in the event loop#740

Merged
bdraco merged 7 commits into
python-zeroconf:masterfrom
bdraco:add_listener_thread_safety
Jun 19, 2021
Merged

Run question answer callbacks from add_listener in the event loop#740
bdraco merged 7 commits into
python-zeroconf:masterfrom
bdraco:add_listener_thread_safety

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 19, 2021

  • Calling async_update_records and async_update_records_complete should always
    happen in the event loop to ensure implementers do not need to worry about
    thread safety

bdraco added 3 commits June 18, 2021 20:32
@bdraco
Run question answer callbacks from add_listener in the event loop
45c166d 
- Calling async_update_records and async_update_records_complete should always
  happen in the event loop to ensure implementers do not need to worry about
  thread safety
@bdraco
black
f89347e
@bdraco
mypy
bf3b738
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 19, 2021 •
edited
Loading

Codecov Report

Merging #740 (949c85c) into master (5feda7e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   98.36%   98.31%   -0.05%     
==========================================
  Files          18       18              
  Lines        2198     2200       +2     
  Branches      385      385              
==========================================
+ Hits         2162     2163       +1     
  Misses         23       23              
- Partials       13       14       +1
Impacted Files Coverage Δ
zeroconf/aio.py 99.39% <ø> (-0.01%) ⬇️
zeroconf/_handlers.py 100.00% <100.00%> (ø)
zeroconf/_services/__init__.py 97.08% <100.00%> (-0.03%) ⬇️
zeroconf/_utils/aio.py 96.42% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5feda7e...949c85c. Read the comment docs.

@bdraco bdraco merged commit c8e15dd into python-zeroconf:master Jun 19, 2021
@bdraco bdraco deleted the add_listener_thread_safety branch June 19, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdraco @codecov-commenter