Remove second level caching from ServiceBrowsers#737
Merged
bdraco merged 5 commits intoJun 19, 2021
Conversation
- The ServiceBrowser had its own cache of the last time it saw a service which was reimplementing the DNSCache and presenting a source of truth problem that lead to unexpected queries when the two disagreed.
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 18 18
Lines 2198 2198
Branches 385 385
=======================================
Hits 2161 2161
Misses 23 23
Partials 14 14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saw a service which was reimplementing the DNSCache and
presenting a source of truth problem that lead to unexpected
queries when the two disagreed.
Fixes #720