Skip to content

Breakout ServiceBrowser handler from listener creation#736

Merged
bdraco merged 3 commits into
python-zeroconf:masterfrom
bdraco:service_browser_breakout
Jun 19, 2021
Merged

Breakout ServiceBrowser handler from listener creation#736
bdraco merged 3 commits into
python-zeroconf:masterfrom
bdraco:service_browser_breakout

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 19, 2021

  • Add coverage for the handler from listener

- Add coverage for the handler from listener
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #736 (73d7a1c) into master (50af944) will increase coverage by 0.14%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   98.15%   98.30%   +0.14%     
==========================================
  Files          18       18              
  Lines        2168     2177       +9     
  Branches      377      382       +5     
==========================================
+ Hits         2128     2140      +12     
+ Misses         25       23       -2     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
zeroconf/_services/__init__.py 97.09% <92.85%> (+0.73%) ⬆️
zeroconf/_dns.py 100.00% <0.00%> (ø)
zeroconf/_handlers.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50af944...73d7a1c. Read the comment docs.

@bdraco bdraco merged commit 35ac7a3 into python-zeroconf:master Jun 19, 2021
@bdraco bdraco deleted the service_browser_breakout branch June 19, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants