Skip to content

Switch to using DNSRRSet in RecordManager#735

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:use_rrset_in_record_manager
Jun 19, 2021
Merged

Switch to using DNSRRSet in RecordManager#735
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:use_rrset_in_record_manager

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 19, 2021

  • RRSet is able to do O(1) lookups of records assuming
    there are no collisions.

Builds on the test coverage added in #734

- RRSet is able to do O(1) lookups of records assuming
  there are no collisions.
@bdraco bdraco changed the title Switch to using RRSet in RecordManager Switch to using DNSRRSet in RecordManager Jun 19, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #735 (f0b3d79) into master (50af944) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   98.15%   98.16%           
=======================================
  Files          18       18           
  Lines        2168     2176    +8     
  Branches      377      382    +5     
=======================================
+ Hits         2128     2136    +8     
  Misses         25       25           
  Partials       15       15           
Impacted Files Coverage Δ
zeroconf/_dns.py 100.00% <100.00%> (ø)
zeroconf/_handlers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50af944...f0b3d79. Read the comment docs.

@bdraco bdraco merged commit c035925 into python-zeroconf:master Jun 19, 2021
@bdraco bdraco deleted the use_rrset_in_record_manager branch June 19, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants