Add fast cache lookup functions#732
Merged
bdraco merged 26 commits intoJun 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 98.16% 98.17% +0.01%
==========================================
Files 18 18
Lines 2176 2197 +21
Branches 382 385 +3
==========================================
+ Hits 2136 2157 +21
Misses 25 25
Partials 15 15
Continue to review full report at Codecov.
|
…into non_threadsafe_cache_lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of our lookups happen in the event loop so there is no need
for them to be threadsafe. Now that the codebase is more clear about what
needs to be threadsafe and what does not need to be threadsafe we can use
the much faster non-threadsafe versions in the places where we are calling
from the event loop.
Supports #720