Skip to content

Fix server cache to be case-insensitive#731

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:server_cache_uppercase
Jun 18, 2021
Merged

Fix server cache to be case-insensitive#731
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:server_cache_uppercase

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 18, 2021

  • If the server name had uppercase chars and any of the
    matching records were lowercase, the server would not be
    found

- If the server name had uppercase chars and any of the
  matching records were lowercase, the server would not be
  found
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #731 (f323f07) into master (88aa610) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   98.15%   97.87%   -0.28%     
==========================================
  Files          18       18              
  Lines        2168     2168              
  Branches      377      377              
==========================================
- Hits         2128     2122       -6     
- Misses         25       29       +4     
- Partials       15       17       +2     
Impacted Files Coverage Δ
zeroconf/_cache.py 100.00% <100.00%> (ø)
zeroconf/_utils/net.py 91.20% <0.00%> (-3.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88aa610...f323f07. Read the comment docs.

@bdraco bdraco merged commit 3ee9b65 into python-zeroconf:master Jun 18, 2021
@bdraco bdraco deleted the server_cache_uppercase branch June 18, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants