Prefix cache functions that are non threadsafe with async_#724
Merged
Conversation
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 97.87% 97.92% +0.04%
==========================================
Files 18 18
Lines 2168 2168
Branches 377 377
==========================================
+ Hits 2122 2123 +1
Misses 29 29
+ Partials 17 16 -1
Continue to review full report at Codecov.
|
Member
Author
|
Can't do this yet because there is a bug in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding (
zc.cache.add->zc.cache.async_add_records), removing (zc.cache.remove->zc.cache.async_remove_records), and expiring the cache (zc.cache.expire->zc.cache.async_expire) the cache is not threadsafe and must be called from the event loop (previously the Engine select loop before 0.32)These functions should only be run from the event loop as they are NOT thread safe.
We never expect these functions will be called externally, however it was possible so this is documented as a breaking change. It is highly recommended that external callers do not modify the cache directly.