Skip to content

Add async_apple_scanner example#719

Merged
bdraco merged 32 commits into
python-zeroconf:masterfrom
bdraco:apple_scanner_example
Jun 21, 2021
Merged

Add async_apple_scanner example#719
bdraco merged 32 commits into
python-zeroconf:masterfrom
bdraco:apple_scanner_example

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 18, 2021

Unicast example
python3 async_apple_scanner.py --target 192.168.210.219

Multicast example
python3 async_apple_scanner.py

closes #702

Comment thread zeroconf/__init__.py Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #719 (f856be6) into master (135983c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          21       21           
  Lines        2260     2260           
  Branches      386      386           
=======================================
  Hits         2231     2231           
  Misses         18       18           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135983c...f856be6. Read the comment docs.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jun 19, 2021

Once we have #721 sorted out, I think we can avoid exposing generate_service_query and use an AsyncServiceBrowser. That would be a much cleaner implementation

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jun 20, 2021

I changed the example to ask QU questions in 6e8e2d3 (#719) which usually means immediate response

Let me know if that looks better.

If so we can expose something to flip the QU bit on even when asking multicast

postlund/pyatv#951 (comment)

@bdraco bdraco marked this pull request as ready for review June 21, 2021 05:14
@bdraco bdraco changed the title Add apple_scanner example Add async_apple_scanner example Jun 21, 2021
@bdraco bdraco merged commit 62dc9c9 into python-zeroconf:master Jun 21, 2021
@bdraco bdraco deleted the apple_scanner_example branch June 21, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide example of asking a QU Question

2 participants