Synchronize created time for incoming and outgoing queries#709
Merged
Conversation
c07bb64 to
ae9877d
Compare
- The created time would differ by a few ms for records, these should all be the same in each packet to reduce unexpected inconsistency - Records received in the same response MUST be subject to fate sharing. Its possible we could end up expiring part of the unique record set because one of the addresses is a few ms older. Fixes python-zeroconf#700
ae9877d to
ada4280
Compare
Member
Author
|
Looks good
|
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
Jun 17, 2021
Followup to python-zeroconf#709 for missed locations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The created time would differ by a few ms for records, these
should all be the same in each packet to reduce unexpected
inconsistency
Records received in the same response MUST be subject to fate
sharing. Its possible we could end up expiring part of the unique
record set because one of the addresses is a few ms older.
Fixes #700