Efficiently bucket queries with known answers#698
Merged
Conversation
- Aggregate queries so that as many known answers as possible fit in the same packet without having known answers spill over into the next packet unless the question and known answers are always going to exceed the packet size. - Some responders do not implement multi-packet known answer suppression so we try to keep all the known answers in the same packet as the questions.
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 98.15% 98.23% +0.07%
==========================================
Files 17 17
Lines 2118 2153 +35
Branches 372 376 +4
==========================================
+ Hits 2079 2115 +36
Misses 23 23
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
Member
Author
|
Moved this to production testing and right away all the truncated queries are gone except for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregate queries so that as many known answers as possible fit in the same packet
without having known answers spill over into the next packet unless the
question and known answers are always going to exceed the packet size.
Some responders do not implement multi-packet known answer suppression
so we try to keep all the known answers in the same packet as the
questions.
Basic design is extensible to other record types besides PTR, however
we currently don't need to support any other record types.
Fixes #691