Ensure services are removed from the registry when calling unregister_all_services#644
Merged
Merged
Conversation
589e7b9 to
4e65388
Compare
Member
Author
|
There is a bug in the names test were we reuse service info and it gets mutated |
…_all_services - There was a race condition where a query could be answered for a service in the registry while goodbye packets which could result a fresh record being broadcast after the goodbye if a query came in at just the right time. To avoid this, we now remove the services from the registry right after we generate the goodbye packet
4e65388 to
bce7a15
Compare
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 96.38% 96.39% +0.01%
==========================================
Files 17 17
Lines 2046 2054 +8
Branches 352 354 +2
==========================================
+ Hits 1972 1980 +8
Misses 43 43
Partials 31 31
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the registry while goodbye packets which could result a fresh record
being broadcast after the goodbye if a query came in at just the right
time. To avoid this, we now remove the services from the registry right
after we generate the goodbye packet