Skip to content

Mark zeroconf.utils as protected by renaming to zeroconf._utils#582

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_utils
Jun 13, 2021
Merged

Mark zeroconf.utils as protected by renaming to zeroconf._utils#582
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_utils

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 13, 2021

  • The public API should only access zeroconf and zeroconf.aio
    as internals may be relocated between releases

- The public API should only access zeroconf and zeroconf.aio
  as internals may be relocated between releases
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #582 (5ad8ef8) into master (a16e85b) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   94.77%   94.52%   -0.26%     
==========================================
  Files          18       18              
  Lines        1954     1954              
  Branches      349      349              
==========================================
- Hits         1852     1847       -5     
- Misses         57       60       +3     
- Partials       45       47       +2     
Impacted Files Coverage Δ
zeroconf/_utils/aio.py 96.42% <ø> (ø)
zeroconf/_utils/name.py 100.00% <ø> (ø)
zeroconf/_utils/net.py 85.94% <ø> (ø)
zeroconf/_utils/struct.py 100.00% <ø> (ø)
zeroconf/_utils/time.py 100.00% <ø> (ø)
zeroconf/__init__.py 90.00% <100.00%> (ø)
zeroconf/_cache.py 100.00% <100.00%> (ø)
zeroconf/_core.py 88.66% <100.00%> (+0.33%) ⬆️
zeroconf/_dns.py 98.21% <100.00%> (ø)
zeroconf/_handlers.py 96.63% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16e85b...5ad8ef8. Read the comment docs.

@bdraco bdraco merged commit cc5bc36 into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the protect_utils branch June 13, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants