Skip to content

Mark zeroconf.cache as protected by renaming to zeroconf._cache#581

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_cache
Jun 13, 2021
Merged

Mark zeroconf.cache as protected by renaming to zeroconf._cache#581
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_cache

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 13, 2021

  • The public API should only access zeroconf and zeroconf.aio
    as internals may be relocated between releases

- The public API should only access zeroconf and zeroconf.aio
  as internals may be relocated between releases
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #581 (32dc557) into master (241700a) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   95.29%   94.47%   -0.82%     
==========================================
  Files          18       18              
  Lines        1954     1954              
  Branches      349      349              
==========================================
- Hits         1862     1846      -16     
- Misses         48       62      +14     
- Partials       44       46       +2     
Impacted Files Coverage Δ
zeroconf/_cache.py 100.00% <ø> (ø)
zeroconf/_dns.py 98.21% <ø> (ø)
zeroconf/__init__.py 90.00% <100.00%> (ø)
zeroconf/_core.py 88.33% <100.00%> (-2.00%) ⬇️
zeroconf/utils/net.py 85.94% <0.00%> (-4.33%) ⬇️
zeroconf/const.py 97.26% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241700a...32dc557. Read the comment docs.

@bdraco bdraco merged commit a16e85b into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the protect_cache branch June 13, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants