Skip to content

Mark zeroconf.exceptions as protected by renaming to zeroconf._exceptions#580

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_exceptions
Jun 13, 2021
Merged

Mark zeroconf.exceptions as protected by renaming to zeroconf._exceptions#580
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:protect_exceptions

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 13, 2021

  • The public API should only access zeroconf and zeroconf.aio
    as internals may be relocated between releases

@bdraco bdraco changed the title Mark zeroconf.exceptions as protected by renaming to zeroconf._except… Mark zeroconf.exceptions as protected by renaming to zeroconf._exceptions Jun 13, 2021
…ions

- The public API should only access zeroconf and zeroconf.aio
  as internals may be relocated between releases
@bdraco bdraco force-pushed the protect_exceptions branch from 0be6dcf to 9d30144 Compare June 13, 2021 19:21
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #580 (9d30144) into master (500066f) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   95.18%   95.03%   -0.16%     
==========================================
  Files          18       18              
  Lines        1954     1954              
  Branches      349      349              
==========================================
- Hits         1860     1857       -3     
- Misses         51       52       +1     
- Partials       43       45       +2     
Impacted Files Coverage Δ
zeroconf/_exceptions.py 100.00% <ø> (ø)
zeroconf/__init__.py 90.00% <100.00%> (ø)
zeroconf/_core.py 88.66% <100.00%> (-0.67%) ⬇️
zeroconf/_dns.py 98.21% <100.00%> (ø)
zeroconf/aio.py 99.40% <100.00%> (ø)
zeroconf/services/__init__.py 92.96% <100.00%> (-0.27%) ⬇️
zeroconf/services/registry.py 98.00% <100.00%> (ø)
zeroconf/utils/name.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500066f...9d30144. Read the comment docs.

@bdraco bdraco merged commit 241700a into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the protect_exceptions branch June 13, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants