Skip to content

Mark zeroconf.dns as protected by renaming to zeroconf._dns#574

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:dns_protected
Jun 13, 2021
Merged

Mark zeroconf.dns as protected by renaming to zeroconf._dns#574
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:dns_protected

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 13, 2021

  • The public API should only access zeroconf and zeroconf.aio
    as internals may be relocated between releases

@bdraco bdraco force-pushed the dns_protected branch 2 times, most recently from b50fb5b to 81521aa Compare June 13, 2021 11:24
@bdraco bdraco changed the title Make zeroconf.dns a protected class as zeroconf._dns Mark zeroconf.dns as protected by renaming to zeroconf._dns Jun 13, 2021
- The public API should only access zeroconf and zeroconf.aio
  as internals may be relocated between releases
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #574 (85eedb2) into master (f10a562) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   95.19%   94.78%   -0.41%     
==========================================
  Files          18       18              
  Lines        1955     1955              
  Branches      349      349              
==========================================
- Hits         1861     1853       -8     
- Misses         51       57       +6     
- Partials       43       45       +2     
Impacted Files Coverage Δ
zeroconf/_dns.py 98.21% <ø> (ø)
zeroconf/__init__.py 90.00% <100.00%> (ø)
zeroconf/aio.py 99.40% <100.00%> (ø)
zeroconf/cache.py 100.00% <100.00%> (ø)
zeroconf/core.py 88.33% <100.00%> (-1.00%) ⬇️
zeroconf/handlers.py 96.63% <100.00%> (ø)
zeroconf/services/__init__.py 92.96% <100.00%> (-0.27%) ⬇️
zeroconf/utils/net.py 88.10% <0.00%> (-2.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10a562...85eedb2. Read the comment docs.

@bdraco bdraco merged commit 0e61b15 into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the dns_protected branch June 13, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants