Skip to content

Move exceptions tests to test_exceptions #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jun 13, 2021
Merged

Move exceptions tests to test_exceptions #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 156 additions & 0 deletions tests/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-


""" Unit tests for zeroconf.exceptions """

import logging
import unittest
import unittest.mock

import zeroconf as r
from zeroconf import (
ServiceInfo,
Zeroconf,
)


log = logging.getLogger('zeroconf')
original_logging_level = logging.NOTSET


def setup_module():
global original_logging_level
original_logging_level = log.level
log.setLevel(logging.DEBUG)


def teardown_module():
if original_logging_level != logging.NOTSET:
log.setLevel(original_logging_level)


class Exceptions(unittest.TestCase):

browser = None # type: Zeroconf

@classmethod
def setUpClass(cls):
cls.browser = Zeroconf(interfaces=['127.0.0.1'])

@classmethod
def tearDownClass(cls):
cls.browser.close()
del cls.browser

def test_bad_service_info_name(self):
self.assertRaises(r.BadTypeInNameException, self.browser.get_service_info, "type", "type_not")

def test_bad_service_names(self):
bad_names_to_try = (
'',
'local',
'_tcp.local.',
'_udp.local.',
'._udp.local.',
'_@._tcp.local.',
'_A@._tcp.local.',
'_x--x._tcp.local.',
'_-x._udp.local.',
'_x-._tcp.local.',
'_22._udp.local.',
'_2-2._tcp.local.',
'_1234567890-abcde._udp.local.',
'\x00._x._udp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, self.browser.get_service_info, name, 'x.' + name)

def test_bad_local_names_for_get_service_info(self):
bad_names_to_try = (
'homekitdev._nothttp._tcp.local.',
'homekitdev._http._udp.local.',
)
for name in bad_names_to_try:
self.assertRaises(
r.BadTypeInNameException, self.browser.get_service_info, '_http._tcp.local.', name
)

def test_good_instance_names(self):
assert r.service_type_name('.._x._tcp.local.') == '_x._tcp.local.'
assert r.service_type_name('x.sub._http._tcp.local.') == '_http._tcp.local.'
assert (
r.service_type_name('6d86f882b90facee9170ad3439d72a4d6ee9f511._zget._http._tcp.local.')
== '_http._tcp.local.'
)

def test_good_instance_names_without_protocol(self):
good_names_to_try = (
"Rachio-C73233.local.",
'YeelightColorBulb-3AFD.local.',
'YeelightTunableBulb-7220.local.',
"AlexanderHomeAssistant 74651D.local.",
'iSmartGate-152.local.',
'MyQ-FGA.local.',
'lutron-02c4392a.local.',
'WICED-hap-3E2734.local.',
'MyHost.local.',
'MyHost.sub.local.',
)
for name in good_names_to_try:
assert r.service_type_name(name, strict=False) == 'local.'

for name in good_names_to_try:
# Raises without strict=False
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_bad_types(self):
bad_names_to_try = (
'._x._tcp.local.',
'a' * 64 + '._sub._http._tcp.local.',
'a' * 62 + u'â._sub._http._tcp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_bad_sub_types(self):
bad_names_to_try = (
'_sub._http._tcp.local.',
'._sub._http._tcp.local.',
'\x7f._sub._http._tcp.local.',
'\x1f._sub._http._tcp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_good_service_names(self):
good_names_to_try = (
('_x._tcp.local.', '_x._tcp.local.'),
('_x._udp.local.', '_x._udp.local.'),
('_12345-67890-abc._udp.local.', '_12345-67890-abc._udp.local.'),
('x._sub._http._tcp.local.', '_http._tcp.local.'),
('a' * 63 + '._sub._http._tcp.local.', '_http._tcp.local.'),
('a' * 61 + u'â._sub._http._tcp.local.', '_http._tcp.local.'),
)

for name, result in good_names_to_try:
assert r.service_type_name(name) == result

assert r.service_type_name('_one_two._tcp.local.', strict=False) == '_one_two._tcp.local.'

def test_invalid_addresses(self):
type_ = "_test-srvc-type._tcp.local."
name = "xxxyyy"
registration_name = "%s.%s" % (name, type_)

bad = ('127.0.0.1', '::1', 42)
for addr in bad:
self.assertRaisesRegex(
TypeError,
'Addresses must be bytes',
ServiceInfo,
type_,
registration_name,
port=80,
addresses=[addr],
)
126 changes: 0 additions & 126 deletions tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,132 +247,6 @@ def generate_host(zc, host_name, type_):
zc.send(out)


class Exceptions(unittest.TestCase):

browser = None # type: Zeroconf

@classmethod
def setUpClass(cls):
cls.browser = Zeroconf(interfaces=['127.0.0.1'])

@classmethod
def tearDownClass(cls):
cls.browser.close()
del cls.browser

def test_bad_service_info_name(self):
self.assertRaises(r.BadTypeInNameException, self.browser.get_service_info, "type", "type_not")

def test_bad_service_names(self):
bad_names_to_try = (
'',
'local',
'_tcp.local.',
'_udp.local.',
'._udp.local.',
'_@._tcp.local.',
'_A@._tcp.local.',
'_x--x._tcp.local.',
'_-x._udp.local.',
'_x-._tcp.local.',
'_22._udp.local.',
'_2-2._tcp.local.',
'_1234567890-abcde._udp.local.',
'\x00._x._udp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, self.browser.get_service_info, name, 'x.' + name)

def test_bad_local_names_for_get_service_info(self):
bad_names_to_try = (
'homekitdev._nothttp._tcp.local.',
'homekitdev._http._udp.local.',
)
for name in bad_names_to_try:
self.assertRaises(
r.BadTypeInNameException, self.browser.get_service_info, '_http._tcp.local.', name
)

def test_good_instance_names(self):
assert r.service_type_name('.._x._tcp.local.') == '_x._tcp.local.'
assert r.service_type_name('x.sub._http._tcp.local.') == '_http._tcp.local.'
assert (
r.service_type_name('6d86f882b90facee9170ad3439d72a4d6ee9f511._zget._http._tcp.local.')
== '_http._tcp.local.'
)

def test_good_instance_names_without_protocol(self):
good_names_to_try = (
"Rachio-C73233.local.",
'YeelightColorBulb-3AFD.local.',
'YeelightTunableBulb-7220.local.',
"AlexanderHomeAssistant 74651D.local.",
'iSmartGate-152.local.',
'MyQ-FGA.local.',
'lutron-02c4392a.local.',
'WICED-hap-3E2734.local.',
'MyHost.local.',
'MyHost.sub.local.',
)
for name in good_names_to_try:
assert r.service_type_name(name, strict=False) == 'local.'

for name in good_names_to_try:
# Raises without strict=False
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_bad_types(self):
bad_names_to_try = (
'._x._tcp.local.',
'a' * 64 + '._sub._http._tcp.local.',
'a' * 62 + u'â._sub._http._tcp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_bad_sub_types(self):
bad_names_to_try = (
'_sub._http._tcp.local.',
'._sub._http._tcp.local.',
'\x7f._sub._http._tcp.local.',
'\x1f._sub._http._tcp.local.',
)
for name in bad_names_to_try:
self.assertRaises(r.BadTypeInNameException, r.service_type_name, name)

def test_good_service_names(self):
good_names_to_try = (
('_x._tcp.local.', '_x._tcp.local.'),
('_x._udp.local.', '_x._udp.local.'),
('_12345-67890-abc._udp.local.', '_12345-67890-abc._udp.local.'),
('x._sub._http._tcp.local.', '_http._tcp.local.'),
('a' * 63 + '._sub._http._tcp.local.', '_http._tcp.local.'),
('a' * 61 + u'â._sub._http._tcp.local.', '_http._tcp.local.'),
)

for name, result in good_names_to_try:
assert r.service_type_name(name) == result

assert r.service_type_name('_one_two._tcp.local.', strict=False) == '_one_two._tcp.local.'

def test_invalid_addresses(self):
type_ = "_test-srvc-type._tcp.local."
name = "xxxyyy"
registration_name = "%s.%s" % (name, type_)

bad = ('127.0.0.1', '::1', 42)
for addr in bad:
self.assertRaisesRegex(
TypeError,
'Addresses must be bytes',
ServiceInfo,
type_,
registration_name,
port=80,
addresses=[addr],
)


class TestDnsIncoming(unittest.TestCase):
def test_incoming_exception_handling(self):
generated = r.DNSOutgoing(0)
Expand Down