Skip to content

Breakout service classes into zeroconf.services#544

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:breakout_services
Jun 13, 2021
Merged

Breakout service classes into zeroconf.services#544
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:breakout_services

Conversation

@bdraco

@bdraco bdraco commented Jun 13, 2021

Copy link
Copy Markdown
Member

No description provided.

Comment thread zeroconf/services.py Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ended up in the wrong place, it should live here

@bdraco bdraco force-pushed the breakout_services branch 2 times, most recently from 3e3ac92 to 98bda76 Compare June 13, 2021 00:11
@bdraco

bdraco commented Jun 13, 2021

Copy link
Copy Markdown
Member Author

Can't move ZeroconfServiceTypes right since it has too tight of coupling to ServiceListener, ServiceBrowser and Zeroconf

@bdraco bdraco force-pushed the breakout_services branch 4 times, most recently from cbe4729 to 44cc8ea Compare June 13, 2021 00:30
@bdraco bdraco force-pushed the breakout_services branch from 44cc8ea to 6face29 Compare June 13, 2021 00:30
@codecov-commenter

codecov-commenter commented Jun 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #544 (6face29) into master (b4814f5) will decrease coverage by 0.06%.
The diff coverage is 93.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   94.08%   94.02%   -0.07%     
==========================================
  Files          12       13       +1     
  Lines        1911     1924      +13     
  Branches      350      351       +1     
==========================================
+ Hits         1798     1809      +11     
- Misses         67       68       +1     
- Partials       46       47       +1     
Impacted Files Coverage Δ
zeroconf/services.py 92.95% <92.95%> (ø)
zeroconf/__init__.py 91.51% <100.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4814f5...6face29. Read the comment docs.

@bdraco bdraco merged commit bdea21c into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the breakout_services branch June 13, 2021 00:36
@bdraco bdraco mentioned this pull request Jun 13, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants