Breakout network utils into zeroconf.utils.net#537
Merged
Conversation
11 tasks
41345e2 to
21649d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 94.00% 94.03% +0.03%
==========================================
Files 8 9 +1
Lines 1885 1895 +10
Branches 350 350
==========================================
+ Hits 1772 1782 +10
Misses 67 67
Partials 46 46
Continue to review full report at Codecov.
|
Member
Author
|
There is some coverage missing for the moved functions. Should add this in a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports #521