Skip to content

Move threading daemon property into ServiceBrowser class #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jun 7, 2021
Merged

Move threading daemon property into ServiceBrowser class #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zeroconf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,6 @@ def __init__(
for check_type_ in self.types:
if not check_type_.endswith(service_type_name(check_type_, strict=False)):
raise BadTypeInNameException
self.daemon = True
self.zc = zc
self.addr = addr
self.port = port
Expand Down Expand Up @@ -1841,6 +1840,7 @@ def __init__(
) -> None:
threading.Thread.__init__(self)
super().__init__(zc, type_, handlers=handlers, listener=listener, addr=addr, port=port, delay=delay)
self.daemon = True
self.start()
self.name = "zeroconf-ServiceBrowser-%s-%s" % (
'-'.join([type_[:-7] for type_ in self.types]),
Expand Down