Reduce the time window that the handlers lock is held#287
Merged
Conversation
d6588fe to
6b784fc
Compare
a8c8a97 to
b9939c9
Compare
This was referenced Aug 22, 2020
b9939c9 to
90c4e35
Compare
Member
Author
|
Pushing a rebase to get this in sync with HEAD |
Only hold the lock if we have an update.
90c4e35 to
193ad11
Compare
Collaborator
|
@mattsaxon do you see any issues with this? |
Collaborator
|
@jstasiak looks very sensible to me! |
Collaborator
|
Cheers, merging then! |
Member
Author
|
@jstasiak TYVM. Can we get a release? I'm hoping this solves the round of homekit cases 🤞 |
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Aug 30, 2020
Changes: python-zeroconf/python-zeroconf#287 Hopefully this will fix the last round of HomeKit issues
21 tasks
Collaborator
|
@bdraco No problem. Sure, 0.28.3 is out with your change! |
Member
Author
Thank you! |
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Aug 31, 2020
Changes: python-zeroconf/python-zeroconf#287 Hopefully this will fix the last round of HomeKit issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, I'm still seeing what I think are instances of #255 on very busy networks.
This builds on #258 to only hold the lock if we have an update.
@mattsaxon Does this violate any of your assumptions ?