Only install enum34 when Python version < 3.4#22
Closed
brisad wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thank you for the patch. I want to keep providing universal wheels so I won't merge this change but I'll figure out other way to deal with this. |
jstasiak
added a commit
that referenced
this pull request
Jul 11, 2015
This is in order for the package's installation to work on Python 3.4+, solves the same issue as #22.
Collaborator
|
@brisad Thank you once again for the patch, ignoring my desire to keep using universal wheels it's perfectly fine patch so I feel bad for not merging it. My fix is released as 0.17.2 on PyPI, can you let me know it works for you? |
Author
|
@jstasiak Yes, I've tried now and it works fine. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot install enum34 in Python 3.4.3. I get a similar problem as is described here: opentok/Opentok-Python-SDK#70
Without the dependency, python-zeroconf works fine.