fix: fix core reliability, concurrency, and performance issues#1795
Open
roshhellwett wants to merge 4 commits into
Open
fix: fix core reliability, concurrency, and performance issues#1795roshhellwett wants to merge 4 commits into
roshhellwett wants to merge 4 commits into
Conversation
- Pin Cython to 3.2.5 in pyproject.toml to resolve native build failures. - Resolve syntax error in _logger.py module docstring. - Optimize ServiceRegistry by migrating server and type storage from lists to dicts, enabling O(1) removals and preventing CPU spikes under load. - Harden RecordManager by utilizing set.discard() to avoid KeyError crashes during asynchronous listener removal. - Fix python-zeroconf#1780: Stop in-place mutation of cached DNSRecord TTLs to prevent shared state corruption across event loop listeners. - Update tests to accommodate cache architectural changes and resolve iterator mutations.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
- Coverage 99.77% 99.69% -0.09%
==========================================
Files 33 33
Lines 3536 3550 +14
Branches 498 505 +7
==========================================
+ Hits 3528 3539 +11
- Misses 5 6 +1
- Partials 3 5 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNSRecordinstances in place to expire TTL #1780: Stop in-place mutation of cached DNSRecord TTLs to prevent shared state corruption across event loop listeners.