Skip to content

chore: enable ruff PT006/PT007 parametrize tuple rules#1749

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bluetoothbot:koan/fix-issue-1748
May 20, 2026
Merged

chore: enable ruff PT006/PT007 parametrize tuple rules#1749
bdraco merged 1 commit into
python-zeroconf:masterfrom
bluetoothbot:koan/fix-issue-1748

Conversation

@bluetoothbot
Copy link
Copy Markdown
Contributor

@bluetoothbot bluetoothbot commented May 20, 2026

Summary

Enable ruff PT006/PT007 in tests by removing the per-file-ignores and fixing the 5 remaining violations across tests/utils/test_name.py and tests/utils/test_net.py.

Fixes #1748

Changes

  • Drop PT006 and PT007 from [tool.ruff.lint.per-file-ignores] for tests/**/*.
  • Convert argnames to tuple form and values to list-of-tuples in the three remaining pytest.mark.parametrize calls.

Test plan

  • poetry run ruff check --no-cache — passes.
  • poetry run pytest tests/utils/test_name.py tests/utils/test_net.py -v — 33 passed, 1 skipped.

Generated by Kōan /fix


Quality Report

Changes: 3 files changed, 7 insertions(+), 9 deletions(-)

Code scan: clean

Tests: passed (4 PASSED)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (a096238) to head (30574f0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3473     3473           
  Branches      482      482           
=======================================
  Hits         3465     3465           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 14 untouched benchmarks


Comparing bluetoothbot:koan/fix-issue-1748 (30574f0) with master (a096238)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (a7cefe9) during the generation of this report, so a096238 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bdraco bdraco marked this pull request as ready for review May 20, 2026 12:45
@bdraco bdraco merged commit 304fae6 into python-zeroconf:master May 20, 2026
36 checks passed
@bluetoothbot bluetoothbot deleted the koan/fix-issue-1748 branch May 20, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable ruff PT006/PT007 parametrize tuple rules

2 participants