test: give IPv6-only loopback find() its own timeout#1721
Merged
Conversation
`test_integration_with_listener_ipv6` flaked on the PyPy 3.10 ubuntu skip_cython runner after #1720 dropped LOOPBACK_FIND_TIMEOUT to 75ms. The IPv6-only path hits `[Errno 101] Network is unreachable` on the `::1` socket on GitHub's Linux runners and has to fall back to the `fe80::` link-local interface; PyPy widens the gap further with JIT warmup. Add IPV6_LOOPBACK_FIND_TIMEOUT (0.5s) and route the V6Only test through it — the IPv4 loopback tests keep the 75ms budget since they never hit the `::1` retry path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1721 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3440 3440
Branches 473 473
=======================================
Hits 3432 3432
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/services/test_types.py::test_integration_with_listener_ipv6flaked onthe PyPy 3.10 / ubuntu /
skip_cythonrunner (failed job) after#1720 dropped
LOOPBACK_FIND_TIMEOUTto 75ms. Give the V6Only path its own500ms budget; leave the IPv4 loopback tests at 75ms.
Details
ZeroconfServiceTypes.find()is justtime.sleep(timeout)— the timeout isthe test's runtime, not a deadline that gets short-circuited by the first
matching response. PR #1720 made that budget viable on loopback by also
patching
_FIRST_QUERY_DELAY_RANDOM_INTERVALfrom RFC 6762 §5.2's 20–120msdown to 1–5ms via the
quick_timingfixture, so the response normally landsinside ~10ms with 7× headroom.
The V6Only path doesn't behave the same way on GitHub's Linux runners:
Every outgoing send on the
::1socket fails and the listener has to fallback to the
fe80::link-local interface. That fallback adds latency theIPv4 loopback path never pays. PyPy widens the gap further with JIT warmup,
and the 75ms budget is no longer enough headroom.
Adding
IPV6_LOOPBACK_FIND_TIMEOUT = 0.5(matches the pre-#1710 value thetest ran with for years) and routing the V6Only test through it. The three
IPv4-loopback tests keep the 75ms budget — they never hit the
::1retrypath.
Test plan
poetry run pytest tests/services/test_types.py -v— all 4 passpoetry run pre-commit run --files tests/__init__.py tests/services/test_types.py— clean