Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (4bae30a) to head (98c3785).

@@           Coverage Diff           @@
##           master    #1711   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3426     3427    +1     
  Branches      471      471           
=======================================
+ Hits         3418     3419    +1     
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merging this PR will not alter performance

✅ 6 untouched benchmarks

_{Comparing bluetoothbot:koan/speed-up-register-random-wait (98c3785) with master (4bae30a)}

all the windows TC tests fail with this pr

    zeroconf:outgoing.py:471 now offsets = questions=1, answers=302, authorities=0, additionals=0
================================== FAILURES ===================================
__________________ test_tc_bit_defers_last_response_missing ___________________

    @patch.object(_listener, "_TC_DELAY_RANDOM_INTERVAL", (10, 20))
    def test_tc_bit_defers_last_response_missing():
        zc = Zeroconf(interfaces=["127.0.0.1"])
        _wait_for_start(zc)
        type_ = "_knowndefer._tcp.local."
        name = "knownname"
        name2 = "knownname2"
        name3 = "knownname3"
    
        registration_name = f"{name}.{type_}"
        registration2_name = f"{name2}.{type_}"
        registration3_name = f"{name3}.{type_}"
    
        desc = {"path": "/~paulsm/"}
        server_name = "ash-2.local."
        server_name2 = "ash-3.local."
        server_name3 = "ash-4.local."
    
        info = r.ServiceInfo(
            type_,
            registration_name,
            80,
            0,
            0,
            desc,
            server_name,
            addresses=[socket.inet_aton("10.0.1.2")],
        )
        info2 = r.ServiceInfo(
            type_,
            registration2_name,
            80,
            0,
            0,
            desc,
            server_name2,
            addresses=[socket.inet_aton("10.0.1.2")],
        )
        info3 = r.ServiceInfo(
            type_,
            registration3_name,
            80,
            0,
            0,
            desc,
            server_name3,
            addresses=[socket.inet_aton("10.0.1.2")],
        )
        zc.registry.async_add(info)
        zc.registry.async_add(info2)
        zc.registry.async_add(info3)
    
        protocol = zc.engine.protocols[0]
        now = r.current_time_millis()
        _clear_cache(zc)
        source_ip = "203.0.113.12"
    
        generated = r.DNSOutgoing(const._FLAGS_QR_QUERY)
        question = r.DNSQuestion(type_, const._TYPE_PTR, const._CLASS_IN)
        generated.add_question(question)
        for _ in range(300):
            # Add so many answers we end up with another packet
            generated.add_answer_at_time(info.dns_pointer(), now)
        generated.add_answer_at_time(info2.dns_pointer(), now)
        generated.add_answer_at_time(info3.dns_pointer(), now)
        packets = generated.packets()
        assert len(packets) == 4
        expected_deferred = []
    
        next_packet = r.DNSIncoming(packets.pop(0))
        expected_deferred.append(next_packet)
        threadsafe_query(zc, protocol, next_packet, source_ip, const._MDNS_PORT, Mock(), ())
        assert protocol._deferred[source_ip] == expected_deferred
        timer1 = protocol._timers[source_ip]
    
        next_packet = r.DNSIncoming(packets.pop(0))
        expected_deferred.append(next_packet)
        threadsafe_query(zc, protocol, next_packet, source_ip, const._MDNS_PORT, Mock(), ())
>       assert protocol._deferred[source_ip] == expected_deferred
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       KeyError: '203.0.113.12'

try harder

@bluetoothbot rr

PR Review — test: shave register/shutdown/TC waits on loopback

The _REGISTER_RANDOM_INTERVAL extraction is clean and the quick_timing fixture change is the right shape. The test_integration race fix (waiting for the first browser query before registering) is well-reasoned and the explanatory comment correctly cites §7.1 known-answer suppression. The test_shutdown_loop patch is a straightforward test-only tightening.

The blocker is test_tc_bit_defers_last_response_missing: it's failing on Windows per @bdraco. The combination of a 10-20ms patched defer interval and a halved cleanup poll budget (800ms → 400ms) doesn't survive Windows' ~15.6ms scheduler tick. Either restore the original cleanup budget or widen the patched random interval (e.g., (20, 50)ms) so the test's timing assumptions hold across the full CI matrix. Once that's resolved this is good to merge.

🔴 Blocking

    for _ in range(20):
        time.sleep(0.02)
        if source_ip not in protocol._timers and source_ip not in protocol._deferred:
            break

🟡 Important

@patch.object(_listener, "_TC_DELAY_RANDOM_INTERVAL", (10, 20))

Checklist

• Cross-platform timing safety — critical ＃1
• Production change matches RFC default
• Race fix in test_integration correctly addresses §7.1 KAS
• Test docstrings/comments don't pad with rationale
• No hand-edits to generated .c files
• No Co-Authored-By trailers

Summary

The _REGISTER_RANDOM_INTERVAL extraction is clean and the quick_timing fixture change is the right shape. The test_integration race fix (waiting for the first browser query before registering) is well-reasoned and the explanatory comment correctly cites §7.1 known-answer suppression. The test_shutdown_loop patch is a straightforward test-only tightening.

The blocker is test_tc_bit_defers_last_response_missing: it's failing on Windows per @bdraco. The combination of a 10-20ms patched defer interval and a halved cleanup poll budget (800ms → 400ms) doesn't survive Windows' ~15.6ms scheduler tick. Either restore the original cleanup budget or widen the patched random interval (e.g., (20, 50)ms) so the test's timing assumptions hold across the full CI matrix. Once that's resolved this is good to merge.

Automated review by Kōanca16a07

@bdraco: all the windows TC tests fail with this pr

The Windows failure is almost certainly the combination of two compounding factors in test_tc_bit_defers_last_response_missing:

1. _TC_DELAY_RANDOM_INTERVAL=(10, 20) is below the Windows scheduler tick (~15.6ms). The asyncio call_later driving the TC defer timer floors at the next tick, so the effective fire time is 15-30ms+ rather than the 10-20ms the patch suggests.

2. The cleanup poll budget was halved — range(8) × sleep(0.1) = 800ms became range(20) × sleep(0.02) = 400ms. Under Windows' coarser time.sleep granularity the wall clock is closer to 620ms, but the asyncio side is racing the same tick and can easily overshoot.

Two options to fix:

• Keep the 800ms cleanup budget (range(40) × sleep(0.02) if you want the finer-grained early exit), or
• Widen the patched random interval to something like (20, 50) or (30, 60) ms — still a 10x speedup over the production (400, 500) ms, but well clear of the Windows tick floor so the timing is deterministic across the CI matrix.

I'd lean toward the second — it preserves the speedup intent of the PR without making the cleanup poll do double duty as a slack budget for scheduler jitter.

Rebase with requested adjustments

Branch koan/speed-up-register-random-wait was rebased onto master and review feedback was applied.

Changes applied

• CI fix: Applied pre-push CI fix
• CI fix: Pre-push CI fix applied

Stats

5 files changed, 23 insertions(+), 9 deletions(-)

CI status

CI will be checked asynchronously.

Automated by Kōan