fix(ci): drop x86_64 mac wheels and clean up obsolete CIBW_SKIP entries#1694
Merged
Conversation
Two issues from the 0.149.2 wheel run:
1. CIBW_ARCHS_MACOS="x86_64 arm64" failed: macos-latest is
macos-15-arm64 and the x86_64 virtualenv was created with the
host arch ("CPython3.10.11.final.0-64-arm64" in cibuildwheel's
log), so the C extension built for arm64 and delocate-wheel
refused the arch-mismatched wheel. Cross-compiling x86_64 from
Apple Silicon is fragile enough that the simpler fix is to drop
x86_64 mac wheels — Apple Silicon has been default since late
2020 and Intel Mac users can still install via sdist.
2. cibuildwheel 3.x dropped Python < 3.8 support and emits
"Invalid skip selector" warnings for cp36-* cp37-* pp36-* pp37-*
on every run. Removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3410 3410
Branches 464 464
=======================================
Hits 3402 3402
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the
0.149.2wheel publish failure (run 25976603151):CIBW_ARCHS_MACOS="x86_64 arm64"failed delocate with an arch-mismatched wheel because cibuildwheel created the x86_64 build's virtualenv on the host arm64 (log showsCPython3.10.11.final.0-64-arm64), so the C extension compiled for arm64 inside a venv tagged x86_64. Cross-compiling x86_64 from Apple Silicon is brittle enough that the simpler answer is to drop x86_64 mac wheels — Apple Silicon has been the default since late 2020 and Intel-Mac users can still install via sdist.CIBW_SKIPentries. cibuildwheel 3.x dropped Python < 3.8 support and emitsInvalid skip selector: 'cp36-*'/'cp37-*'/'pp36-*'/'pp37-*'warnings on every run. Removed.Details
CIBW_ARCHS_MACOS=arm64only affects mac runs; the env var is a no-op on Linux/Windows.Reduced skip list keeps the still-useful entries:
cp38-*,cp39-*,pp38-*,pp39-*(matchesrequires-python = ">=3.10").Test plan
0.149.3.Wheels for macos-latest (manylinux)job succeeds and produces only*-macosx_*_arm64.whl.upload_pypiruns and0.149.3lands on PyPI with the full Linux/Windows/mac-arm64 wheel set.Invalid skip selectorwarnings in cibuildwheel logs.Follow-up
Universal2 wheels (
CIBW_ARCHS_MACOS="universal2") are a possible re-add later if Intel-Mac coverage matters; they build natively on arm64 without the cross-compile issues. Out of scope for this PR.