Skip to content

ci: validate PR title against Conventional Commits#1681

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bluetoothbot:koan/fix-issue-1680
May 16, 2026
Merged

ci: validate PR title against Conventional Commits#1681
bdraco merged 1 commit into
python-zeroconf:masterfrom
bluetoothbot:koan/fix-issue-1680

Conversation

@bluetoothbot
Copy link
Copy Markdown
Contributor

@bluetoothbot bluetoothbot commented May 16, 2026

Summary

PRs in this repo are squash-merged, which means the PR title becomes the subject line of the squashed commit on master. The existing commitlint job only validates the commits inside the PR, leaving the PR title — and therefore the actual commit that ends up on master and drives python-semantic-release — unchecked.

Add a pr-title job that runs amannn/action-semantic-pull-request on pull_request events to lint the title against Conventional Commits, so the squashed commit stays release-tool-friendly even when individual commits inside the PR don't.

Fixes #1680

Changes

  • New pr-title job in .github/workflows/ci.yml, gated on github.event_name == 'pull_request', using a SHA-pinned amannn/action-semantic-pull-request@v6.1.1.

Test plan

  • This PR's own title (ci: validate PR title …) exercises the new check and should pass.
  • Renaming the PR to something non-conventional (e.g. update CI) should turn the Lint PR Title check red; restoring a ci:/fix:/feat: prefix should turn it green again.
  • The job needs to be added to the branch protection's required status checks for the gate to be enforced on merge.

Generated by Kōan /fix


Quality Report

Changes: 1 file changed, 14 insertions(+)

Code scan: clean

Tests: failed (FAILED)

Branch hygiene: clean

Generated by Kōan post-mission quality pipeline

PRs are squash-merged, so the PR title becomes the subject line of the
squashed commit on master. commitlint only validates individual commits
in the PR, leaving the PR title (and therefore the resulting release-
tool-visible commit) unenforced.

Add a pr-title job that runs amannn/action-semantic-pull-request on
pull_request events to validate the title against Conventional Commits.
@bdraco bdraco marked this pull request as ready for review May 16, 2026 06:11
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 16, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing bluetoothbot:koan/fix-issue-1680 (fb15a09) with master (8a7dff9)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (8a7dff9) to head (fb15a09).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1681   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3401     3401           
  Branches      461      461           
=======================================
  Hits         3393     3393           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bdraco bdraco merged commit 1f380b1 into python-zeroconf:master May 16, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ci flow isn't properly enforcing conventional commits in the pr title

2 participants