Skip to content

feat: add simple address resolvers and examples#1499

Merged
bdraco merged 6 commits into
masterfrom
address_resolvers
Jan 30, 2025
Merged

feat: add simple address resolvers and examples#1499
bdraco merged 6 commits into
masterfrom
address_resolvers

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jan 30, 2025 •
edited
Loading

This pattern gets copied into a lot of downstream likes including aioesphomeapi, esphome, https://github.com/aio-libs/aiohttp-asyncmdnsresolver, etc

We can provide these as built-ins since its a common use case

(zeroconf-py3.12) bdraco@Mac python-zeroconf % python3 examples/resolve_address.py homeassistant.local.
DEBUG:asyncio:Using selector: KqueueSelector
homeassistant.local. IP addresses: [ZeroconfIPv4Address('192.168.x.x')]
(zeroconf-py3.12) bdraco@Mac python-zeroconf %

closes #129

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (69f7c13) to head (b0ac474).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1499   +/-   ##
=======================================
  Coverage   99.78%   99.79%           
=======================================
  Files          30       30           
  Lines        3316     3345   +29     
  Branches      455      459    +4     
=======================================
+ Hits         3309     3338   +29     
  Misses          5        5           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1499 will not alter performance

Comparing address_resolvers (b0ac474) with master (69f7c13)

Summary

✅ 6 untouched benchmarks

bdraco
bdraco commented Jan 30, 2025
View reviewed changes
Comment thread examples/resolve_address.py Outdated
@bdraco bdraco marked this pull request as ready for review January 30, 2025 17:30
@bdraco bdraco merged commit ae3c352 into master Jan 30, 2025
@bdraco bdraco deleted the address_resolvers branch January 30, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: resolve a host name to an IP address

1 participant

@bdraco