Skip to content

chore(git): make scripts with shebang executable#1433

Merged
bdraco merged 3 commits into
python-zeroconf:masterfrom
Rotzbua:fix_executable
Jan 8, 2025
Merged

chore(git): make scripts with shebang executable#1433
bdraco merged 3 commits into
python-zeroconf:masterfrom
Rotzbua:fix_executable

Conversation

@Rotzbua
Copy link
Copy Markdown
Contributor

@Rotzbua Rotzbua commented Nov 2, 2024

Add check to pre-commit.

@bdraco bdraco changed the title fix(git): make scripts with shebang executable chore(git): make scripts with shebang executable Nov 15, 2024
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 15, 2024

Thanks @Rotzbua

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 15, 2024

Note: PR is still in draft (not sure if thats on purpose)

@Rotzbua
Copy link
Copy Markdown
Contributor Author

Rotzbua commented Dec 4, 2024

@bdraco I is a draft because I had no time to investigate the unusual: every test is executable

Add check to pre-commit.
Remove executable from tests.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #1433 will not alter performance

Comparing Rotzbua:fix_executable (1b887be) with master (bd84538)

Summary

✅ 3 untouched benchmarks

@Rotzbua Rotzbua marked this pull request as ready for review January 8, 2025 12:30
@Rotzbua Rotzbua requested a review from bdraco January 8, 2025 12:30
@bdraco bdraco merged commit 45c82d1 into python-zeroconf:master Jan 8, 2025
@Rotzbua Rotzbua deleted the fix_executable branch January 8, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants