feat: speed up the query handler#1350
Merged
Merged
Conversation
This reverts commit 9a7f6cd.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 30 30
Lines 3240 3243 +3
Branches 536 536
=======================================
+ Hits 3232 3235 +3
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
bdraco
commented
Dec 19, 2023
Comment on lines
+431
to
+438
| out_queue = self.zc.out_queue | ||
| out_queue.async_add(now, question_answers.mcast_aggregate) | ||
| if question_answers.mcast_aggregate_last_second: | ||
| # https://datatracker.ietf.org/doc/html/rfc6762#section-14 | ||
| # If we broadcast it in the last second, we have to delay | ||
| # at least a second before we send it again | ||
| out_delay_queue = self.zc.out_delay_queue | ||
| out_delay_queue.async_add(now, question_answers.mcast_aggregate_last_second) |
Member
Author
There was a problem hiding this comment.
out_queue and out_delay_queue never change, we could rebind them to the QueryHandler object to avoid the getattr here but it probably doesn't make much difference as they should rarely be called in practice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_assembled_querywas still a bound method on theZeroconfobject. It can be moved to the query handler like we did for the record manager. This meant the listener had to jump back into the python stack for every answer packet when most of them will never be responded to.