Skip to content

feat: small performance improvement for ServiceInfo asking questions #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Dec 15, 2023
Merged

feat: small performance improvement for ServiceInfo asking questions #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zeroconf/_services/info.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@ cdef class ServiceInfo(RecordUpdateListener):
cpdef async_clear_cache(self)

@cython.locals(cache=DNSCache)
cdef _generate_request_query(self, object zc, object now, object question_type)
cdef _generate_request_query(self, object zc, double now, object question_type)
2 changes: 1 addition & 1 deletion src/zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ def _generate_request_query(
out.add_question_or_one_cache(cache, now, name, _TYPE_TXT, _CLASS_IN)
out.add_question_or_all_cache(cache, now, server_or_name, _TYPE_A, _CLASS_IN)
out.add_question_or_all_cache(cache, now, server_or_name, _TYPE_AAAA, _CLASS_IN)
if question_type == DNS_QUESTION_TYPE_QU:
if question_type is DNS_QUESTION_TYPE_QU:
for question in out.questions:
question.unicast = True
return out
Expand Down