Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a200842) 99.77% compared to head (fba7272) 99.77%.
Report is 1 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1322   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          29       29           
  Lines        3087     3104   +17     
  Branches      518      521    +3     
=======================================
+ Hits         3080     3097   +17     
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

That test is failing because there is a precision loss with the float to double conversion.
We should make all the floats doubles ..but for another PR

@bdraco thanks for adding this fix! I was hoping to learn more about this:

scope_id only works on python 3.9+ since < 3.9 doesn't support it

Do you have a reference for this? I'm trying to find out whether it's possible to get the scope id in Python 3.8 some other way and haven't had much luck finding more info yet.

https://docs.python.org/3.8/library/ipaddress.html -- scope_id is missing here

https://docs.python.org/3.9/library/ipaddress.html -- scope_id is present here

Thanks @bdraco !