feat: reduce overhead to process incoming questions#1244
Merged
Conversation
When the mac discovery app is open, the number of questions goes up almost 10x. We can reduce a bit of the overhead by cythonizing the time functions and cimporting it into the hot path
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bdraco
commented
Sep 2, 2023
Comment on lines
+4
to
+5
| from ._protocol.incoming cimport DNSIncoming | ||
| from ._utils.time cimport current_time_millis, millis_to_seconds |
Member
Author
There was a problem hiding this comment.
We still have a lot of float conversions from the constants that we can't patch because it breaks the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the mac discovery app is open, the number of questions goes up almost 10x. We can reduce a bit of the overhead by cythonizing the time functions and cimporting it into the hot path