Skip to content

fix: race with InvalidStateError when async_request times out #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
Aug 3, 2023
Merged

fix: race with InvalidStateError when async_request times out #1208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b22f59
fix: resolve race with InvalidStateError error when async_request tim…
bdraco Aug 3, 2023
80dd199
fix: resolve race with InvalidStateError error when async_request tim…
bdraco Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ def instance_name_from_service_info(info: "ServiceInfo") -> str:
_cached_ip_addresses = lru_cache(maxsize=256)(ip_address)


def _set_future_none_if_not_done(fut: asyncio.Future) -> None:
"""Set a future to None if it is not done."""
if not fut.done(): # pragma: no branch
fut.set_result(None)


class ServiceInfo(RecordUpdateListener):
"""Service information.

Expand Down Expand Up @@ -235,7 +241,7 @@ async def async_wait(self, timeout: float) -> None:
loop = asyncio.get_running_loop()
future = loop.create_future()
self._new_records_futures.append(future)
handle = loop.call_later(millis_to_seconds(timeout), future.set_result, None)
handle = loop.call_later(millis_to_seconds(timeout), _set_future_none_if_not_done, future)
try:
await future
finally:
Expand Down