Skip to content

feat: cython3 support#1190

Merged
bdraco merged 2 commits into
masterfrom
cython3_fixes
Jun 18, 2023
Merged

feat: cython3 support#1190
bdraco merged 2 commits into
masterfrom
cython3_fixes

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 18, 2023

Hide a few more types to prevent them from being cythonized where we want them to stay native py objects

closes #1183

bdraco added 2 commits June 18, 2023 15:15
Hide a few more types to prevent them from being cythonized
where we want them to stay native py objects

fixes #1183
@bdraco bdraco changed the title fix: cython3 support feat: cython3 support Jun 18, 2023
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jun 18, 2023

supporting a new major version should really be a new feature not a fix

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ac5c50a) 99.81% compared to head (c6578fb) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1190   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2719     2721    +2     
  Branches      474      474           
=======================================
+ Hits         2714     2716    +2     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/_cache.py 100.00% <100.00%> (ø)
src/zeroconf/_protocol/incoming.py 99.00% <100.00%> (+<0.01%) ⬆️
src/zeroconf/_protocol/outgoing.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit 8ae8ba1 into master Jun 18, 2023
@bdraco bdraco deleted the cython3_fixes branch June 18, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension build error with Cython-3.0.0b3

1 participant