feat: optimize equality checks for DNS records#1120
Merged
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 22 22
Lines 2567 2590 +23
Branches 454 456 +2
=======================================
+ Hits 2560 2583 +23
Misses 5 5
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
commented
Dec 21, 2022
934ee37 to
12b2fb5
Compare
By moving some of the equality checking to `cdef`s we can avoid the generic python accessors and access the properties directly on the object. This can only be done once it passes the `isinstance` check for the same type.
12b2fb5 to
b3715ba
Compare
Member
Author
|
Looks like the tests are failing because of a bug I fixed with |
Member
Author
|
reverted the fix here and opened #1121 Will make a PR for that |
bdraco
commented
Dec 22, 2022
Member
Author
|
This is what is left that still takes a bit of time which is a wrapper around the incoming parser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving some of the equality checking to
cdefs we can avoid the generic python accessors and access the properties directly on the object. This can only be done once it passes theisinstancecheck for the same type.