Improve cache of decode labels at offset#1097
Merged
Merged
Conversation
This represent a 36% speed up on the incoming parser benchmark
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 23 21 -2
Lines 2547 2458 -89
Branches 506 443 -63
==========================================
- Hits 2546 2457 -89
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did not cache the result of the final decode which meant any label that
used the final decode as part of a future decode had to be decoded again