Fix flakey test_sending_unicast on windows#1083
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 23 23
Lines 2548 2548
Branches 476 476
=======================================
Hits 2546 2546
Misses 1 1
Partials 1 1 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bluetoothbot
added a commit
to bluetoothbot/python-zeroconf
that referenced
this pull request
May 17, 2026
test_sending_unicast asserts that a multicast packet sent from a Zeroconf bound to 127.0.0.1 loops back to its own listener within ~0.5s. On GH Actions Windows runners that multicast loopback is sporadically broken — the test has been flaky since 2022 (python-zeroconf#1083 added a 0.5s retry loop) and even widening the retry to 3s on this branch did not resolve it. Skip on win32 and restore the original 10-iteration buffer for Linux/macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.