Skip to content

Fix run_coro_with_timeout test not running in the CI#1082

Merged
bdraco merged 1 commit into
masterfrom
fix_run_coro_with_timeout_test
Aug 5, 2022
Merged

Fix run_coro_with_timeout test not running in the CI#1082
bdraco merged 1 commit into
masterfrom
fix_run_coro_with_timeout_test

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Aug 5, 2022

SSIA

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1082 (d5032b7) into master (d5032b7) will not change coverage.
The diff coverage is n/a.

❗ Current head d5032b7 differs from pull request most recent head e611f20. Consider uploading reports for the commit e611f20 to get more accurate results

@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          23       23           
  Lines        2548     2548           
  Branches      476      476           
=======================================
  Hits         2546     2546           
  Misses          1        1           
  Partials        1        1           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bdraco bdraco force-pushed the fix_run_coro_with_timeout_test branch from d550cd0 to dfa7573 Compare August 5, 2022 21:37
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Aug 5, 2022

test_service_browser_expire_callbacks is flakey due to thread switching. probably need a wait there

@bdraco bdraco force-pushed the fix_run_coro_with_timeout_test branch from dfa7573 to 8061c0a Compare August 5, 2022 21:53
@bdraco bdraco force-pushed the fix_run_coro_with_timeout_test branch from 8061c0a to e611f20 Compare August 5, 2022 21:54
@bdraco bdraco merged commit b7a24fe into master Aug 5, 2022
@bdraco bdraco deleted the fix_run_coro_with_timeout_test branch August 5, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants