Fix ServiceBrowsers not getting ServiceStateChange.Removed callbacks on PTR record expire#1064
Merged
Merged
Conversation
f927628 to
53e5707
Compare
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 23 23
Lines 2544 2544
Branches 473 473
=======================================
Hits 2542 2542
Misses 1 1
Partials 1 1 Continue to review full report at Codecov.
|
ServiceStateChange.Removed callbacks on PTR record expire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceBrowsers were only getting a
ServiceStateChange.Removedcallback when the record was sent with a TTL of 0. They now correctly get aServiceStateChange.Removedcallback when the record expires as well.cc @AlexxIT