feat: speed up decoding dns questions when processing incoming data (#1168)

bdraco · web-flow · commit f927190cb24f · 2023-05-01T08:17:21.000-05:00
diff --git a/src/zeroconf/_protocol/incoming.pxd b/src/zeroconf/_protocol/incoming.pxd
@@ -38,6 +38,7 @@ from .._dns cimport (
     DNSHinfo,
     DNSNsec,
     DNSPointer,
+    DNSQuestion,
     DNSRecord,
     DNSService,
     DNSText,
@@ -48,11 +49,11 @@ cdef class DNSIncoming:
 
     cdef bint _did_read_others
     cdef public unsigned int flags
-    cdef object offset
+    cdef cython.uint offset
     cdef public bytes data
     cdef unsigned int _data_len
     cdef public cython.dict name_cache
-    cdef public object questions
+    cdef public cython.list questions
     cdef object _answers
     cdef public object id
     cdef public cython.uint num_questions
diff --git a/src/zeroconf/_protocol/incoming.py b/src/zeroconf/_protocol/incoming.py
@@ -211,9 +211,12 @@ def _read_header(self) -> None:
 
     def _read_questions(self) -> None:
         """Reads questions section of packet"""
-        self.questions = [
-            DNSQuestion(self._read_name(), *self._unpack(UNPACK_HH, 4)) for _ in range(self.num_questions)
-        ]
+        for _ in range(self.num_questions):
+            name = self._read_name()
+            type_, class_ = UNPACK_HH(self.data, self.offset)
+            self.offset += 4
+            question = DNSQuestion(name, type_, class_)
+            self.questions.append(question)
 
     def _read_character_string(self) -> bytes:
         """Reads a character string from the packet"""
