Skip to content

feat: speed up decoding dns questions when processing incoming data#1168

Merged
bdraco merged 2 commits into
masterfrom
dns_question
May 1, 2023
Merged

feat: speed up decoding dns questions when processing incoming data#1168
bdraco merged 2 commits into
masterfrom
dns_question

Conversation

@bdraco

@bdraco bdraco commented May 1, 2023

Copy link
Copy Markdown
Member

DNSQuestion is now imported via cimport to reduce overhead. The unpack dispatch is avoided to reduce the stack overhead

@codecov

codecov Bot commented May 1, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4986271) 99.81% compared to head (e0924db) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2657     2662    +5     
  Branches      464      464           
=======================================
+ Hits         2652     2657    +5     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_protocol/incoming.py 98.91% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review May 1, 2023 04:09
@bdraco bdraco changed the title feat: speed up decoding dns questions feat: speed up decoding dns questions when processing incoming data May 1, 2023
@bdraco bdraco merged commit f927190 into master May 1, 2023
@bdraco bdraco deleted the dns_question branch May 1, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant