Skip to content

Fix issue with matplotlib 3.6.0 - #191

Merged
s-celles merged 4 commits into
python-windrose:mainfrom
ocefpaf:fix_mpl_3.6.0
Sep 21, 2022
Merged

s-celles merged 4 commits into
python-windrose:mainfrom
ocefpaf:fix_mpl_3.6.0

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator

This should work with mpl >=3 b/c too, I updated the minimum requirement.

Closes #190

This was referenced Sep 19, 2022
@ocefpaf
ocefpaf force-pushed the fix_mpl_3.6.0 branch 2 times, most recently from f265c45 to 2806e9a Compare September 19, 2022 17:27
@ocefpaf
ocefpaf marked this pull request as draft September 19, 2022 17:32
@ocefpaf

ocefpaf commented Sep 19, 2022

Copy link
Copy Markdown
Collaborator Author

I'm converting this to draft for now b/c I want to add a simple regression test that compares images before we move forward.

@ocefpaf

ocefpaf commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator Author

Without the fix here the tests capture 18 failures, all related to the "pacman" reported #190:

Screenshot from 2022-09-20 14-47-34

@scls19fr this one is ready for review!

@ocefpaf
ocefpaf marked this pull request as ready for review September 20, 2022 17:49
@ocefpaf
ocefpaf requested a review from s-celles September 20, 2022 17:49
@s-celles
s-celles merged commit 545af6a into python-windrose:main Sep 21, 2022
@ocefpaf
ocefpaf deleted the fix_mpl_3.6.0 branch September 21, 2022 11:51
@tacaswell

Copy link
Copy Markdown

This fix may cause issues with older versions of Matplotilb, see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#axes-subclasses-should-override-clear-instead-of-cla

Looking at what cartopy does may be a good reference.

@ocefpaf

ocefpaf commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator Author

This fix may cause issues with older versions of Matplotilb, see https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#axes-subclasses-should-override-clear-instead-of-cla

Looking at what cartopy does may be a good reference.

I tested with 3.5 but I'll test a bit more and pin mpl to a >= ver_that_work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pacman-shaped wind roses

3 participants